Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

load_kube_config_from_dict() support define custom temp files path #233

Merged
merged 1 commit into from
Apr 14, 2021
Merged

load_kube_config_from_dict() support define custom temp files path #233

merged 1 commit into from
Apr 14, 2021

Conversation

onecer
Copy link
Contributor

@onecer onecer commented Apr 12, 2021 •
edited by roycaihw
Loading

Centos '/tmp' will clear files that created over 10 days ago in this directory.

So, If we can define a temp files path then problems will be solved.

It works for k8s config tmp files cleared by centos
and SSLError: FileNotFoundError: [Errno 2] No such file or directory

load_kube_config_from_dict() support define custom temp files path

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @onecer!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 12, 2021
@roycaihw
Copy link
Member

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Apr 12, 2021

please add a test

@onecer
Copy link
Contributor Author

onecer commented Apr 13, 2021

please add a test

done.

yliaog
yliaog reviewed Apr 14, 2021
View reviewed changes
config/kube_config_test.py Show resolved Hide resolved
config/kube_config.py Outdated Show resolved Hide resolved
@yliaog
Copy link
Contributor

yliaog commented Apr 14, 2021

thanks for the pr. please squash the commits.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@yliaog
Copy link
Contributor

yliaog commented Apr 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: onecer, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit f38221c into kubernetes-client:master Apr 14, 2021
@roycaihw roycaihw added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yliaog yliaog yliaog left review comments

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onecer @k8s-ci-robot @roycaihw @yliaog